[Webkit-unassigned] [Bug 57138] WebSocket urls should always be encoded as UTF-8

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57138


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92543|commit-queue?               |commit-queue-
               Flag|                            |




--- Comment #13 from Alexey Proskuryakov <ap at webkit.org>  2011-05-05 22:48:12 PST ---
(From update of attachment 92543)
+        // Use a String instead of a KURL for the url to ensure that WebSocket
+        // parses the url itself using WebSocket rules (must be absolute and
+        // UTF-8 encoded).

I don't see how the comment can be useful to someone reading this code. There is no option to use KURL, so explaining why String is better than KURL is pointless.

Otherwise, looks fine to me. Adam?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.