[Webkit-unassigned] [Bug 60249] Make RenderStyle::setColumnBreakInside() reject unsupported enum values.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 5 20:37:48 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=60249





--- Comment #12 from Luke Macpherson <macpherson at chromium.org>  2011-05-05 20:37:48 PST ---
(In reply to comment #11)
> Created an attachment (id=92534)
 --> (https://bugs.webkit.org/attachment.cgi?id=92534&action=review) [details]
> Patch

(In reply to comment #10)
> (In reply to comment #9)
> > (From update of attachment 92527 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=92527&action=review
> > 
> > > Source/WebCore/rendering/style/RenderStyle.h:1077
> > > +    void setColumnBreakInside(EPageBreak p) { ASSERT(p == PBALWAYS || p == PBAVOID); SET_VAR(rareNonInheritedData.access()->m_multiCol, m_breakInside, p); }
> > 
> > I thought PBALWAS was not allowed?
> 
> Yeah, that's why I removed the r? until I had a chance to fix.

Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list