[Webkit-unassigned] [Bug 60235] Make RenderStyle::setPageBreakInside() reject unsupported enum values.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 5 17:49:10 PDT 2011


--- Comment #10 from Eric Seidel <eric at webkit.org>  2011-05-05 17:49:11 PST ---
(From update of attachment 92509)
View in context: https://bugs.webkit.org/attachment.cgi?id=92509&action=review

> Source/WebCore/rendering/style/RenderStyle.h:1016
> +    void setPageBreakInside(EPageBreak b) { ASSERT(b != PBALWAYS); noninherited_flags._page_break_inside = b; }

So now I ask myself: "self, how many other values for EPageBreak are there?  Why are we blacklisting a single one, instead of whitelisting the supported ones?"

I still think this deserves a comment.  something as simple as:
// EPageBreak supports more values than page-break-inside allows, make sure we're only ever setting valid values.
or something like that.

Thank you for leading this difficult cleanup task!

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list