[Webkit-unassigned] [Bug 17154] [GTK] Widget size negotiation

Thu May 5 15:54:09 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=17154

--- Comment #14 from Martin Robinson <mrobinson at webkit.org>  2011-05-05 15:54:09 PST ---
(In reply to comment #13)
> (In reply to comment #12)

> I am against because I believe the way it's now is the way it's supposed to work in GTK+. I believe if we need to enforce something else for a different use case, then that use case is the one that should override the signal. Can you perhaps elaborate on why we would pack the widget on a box instead of on a ScrollView? Perhaps looking at the use case can help us figure out solutions.  In other news, with GTK+ 3 the size negoatiation story changed to be more like clutter's, so I guess there's some revision we need to do anyway?

My objection is that a user should be able to pack a widget in any of the containers that GTK+ provides and have it play nice. Right now a WebView widget can only grow in anything other than a GtkScrolledWindow. That seems wrong, but I may just misundertand GTK+ here. I also think requesting thousands of pixels during size-request might be causing some performance issues in certain containers. Other ports do not try to grow their widget as large the document content, instead they let the widget itself determine the size of the viewport. Perhaps I'm wrong about the entire thing though.

For GTK+ 3 we are setting both the minimum and natural sizes to the size of the DOM document.

Usecase: Imagine wanting to pack a WebView (sans GtkScrolledWindow) with a fixed size into some container along with some toolbars. Seems like a pretty reasonable usecase. Right now you can't do it without manually overriding the size-request signal.

Honestly though, my real usecase is allowing WebKit to draw and control the main frame scrollbars itself. I'm was very close to having this when I bumped into this bug. I would like to support having main frame scrollbars with and without the GtkScrolledWindow wrapper. This is the only way we will remove the scrollbar race conditions, which plague many of our tests and turn our bots red.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.