[Webkit-unassigned] [Bug 60277] [Meta] Add a WebCore testing harness

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 5 09:58:50 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=60277





--- Comment #2 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2011-05-05 09:58:50 PST ---
So I have a simple/stupid approach mostly using existing machinery:

1) Add ENABLE(TESTING) guard and make sure that all of the harness code is conditionally compiled with this flag;

2) Expose a static isInTestMode flag, which is only true when we're running inside DRT. We already have something like this in Chromium (http://codesearch.google.com/codesearch/p#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/platform/chromium/PlatformBridge.h&l=190)

3) Make it so that iff the isInTestMode flag is true, the window.internals object and all corresponding DOM plumbing are visible.

This way, the production builds should simply always set ENABLE(TESTING) to false and never worry about carrying the extra weight of the testing code.

WDYT?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list