[Webkit-unassigned] [Bug 60258] [GTK] Make native events code more consistent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60258





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-05-05 08:38:37 PST ---
(In reply to comment #2)
> (From update of attachment 92388 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=92388&action=review
> 
> Very nice cleanup, but I do not understand the addition of the copy constructors.
> 
> > Source/WebKit2/Shared/NativeWebMouseEvent.h:52
> > +    NativeWebMouseEvent(const NativeWebMouseEvent&);
> 
> Why is a copy constructor necessary now?

Because the default copy constructor doesn't know how to copy a GdkEvent.

> > Source/WebKit2/Shared/NativeWebWheelEvent.h:52
> > +    NativeWebWheelEvent(const NativeWebWheelEvent&);
> 
> Ditto.
> 
> > Source/WebKit2/Shared/gtk/WebEventFactory.cpp:99
> > +WebMouseEvent WebEventFactory::createWebMouseEvent(const GdkEvent *event, int currentClickCount)
> 
> The asterisk should move to the left here.

Ok.

> > Source/WebKit2/Shared/gtk/WebEventFactory.cpp:141
> > +    switch (reinterpret_cast<const GdkEventScroll*>(event)->direction) {
> 
> It's probably better to write event->scroll.direction.

Ok.

> > Source/WebKit2/Shared/gtk/WebEventFactory.cpp:175
> > +    guint keyval = reinterpret_cast<const GdkEventKey*>(event)->keyval;
> 
> Ditto. event->key.keyval.

Ok.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.