[Webkit-unassigned] [Bug 60246] Move burden of checking for BJustify box alignment into RenderStyle

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60246





--- Comment #7 from Luke Macpherson <macpherson at chromium.org>  2011-05-04 23:35:58 PST ---
(In reply to comment #5)
> (From update of attachment 92372 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=92372&action=review
> 
> >> Source/WebCore/rendering/style/RenderStyle.h:1029
> >> +    void setBoxAlign(EBoxAlignment a)
> > 
> > This guy now wants to be inlined like http://codesearch.google.com/codesearch/p#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/dom/Node.h&l=727&exact_package=chromium
> 
> I don't understand why we want this logic in RenderStyle.  Why should it be impossible to set BJUSTIFY?

These special cases are arising because one enum is being used as a superset of the possible values for multiple properties. In this instance, the EBoxAlignment enum is used for both the BoxPack and BoxAlignment properties, even though they appear to support different but overlapping sets of values. There are numerous other examples of similar enums in this code.

It could be that a better solution is to have two separate enums, though that would require a lot more digging to ensure correctness of the refactoring.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.