[Webkit-unassigned] [Bug 60146] [CMAKE] Refactoring wtf related code.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60146





--- Comment #5 from Ryuan Choi <ryuan.choi at samsung.com>  2011-05-04 21:34:49 PST ---
(In reply to comment #2)
> (From update of attachment 92208 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=92208&action=review
> 
> Expect for the wtf-files, LGTM
> 
> > Source/JavaScriptCore/CMakeLists.txt:-174
> > -
> > -    wtf/DateMath.cpp
> > -    wtf/PageAllocationAligned.cpp
> > -    wtf/PageBlock.cpp
> 
> I'm not sure if that's correct. Some other ports add this to JSC and not to WTF too. (I don't know why they do that and if i remenber corretly I had some problem with this files in in the WinCE port)
> e.g. http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj?rev=83506#L641
> 
> At lest the move of the files can be put into an addtional patch.

I updated my patch.

I checked it using v8 option (in our local branch).
V8 build requires DateMath.cpp (with wtf).
and I hope to seperate wtf from JavaScriptCore to support v8 option.

So, IMO, we'd better to move it into wtf.

I tested on EFL port, but I can't on WinCE port.
Could you give address on WinCE port for this patch, if any issues?

Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.