[Webkit-unassigned] [Bug 60226] Style bot gives bogus newline errors for python code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60226





--- Comment #2 from David Levin <levin at chromium.org>  2011-05-04 18:03:42 PST ---
(In reply to comment #1)
> I wonder if this is not a bogus error, so much as that the diff that we pass to check-webkit-style may be different from the diff that we finally upload (thus the review-tools' line number matching may end up wrong).

imo, the answer is that James needed to update repository. Once his patch mixed with Adam's change here: http://trac.webkit.org/changeset/85727/trunk/Tools/Scripts/webkitpy/common/config/urls.py

Then the error appears. I don't understand why the error wasn't filtered out because I would think that the diff wouldn't include that line since it was part of Adam's patch.


Anyway, you can see where he fixed the error in his check in and it is indeed on line 41.
http://trac.webkit.org/changeset/85797/trunk/Tools/Scripts/webkitpy/common/config/urls.py

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.