[Webkit-unassigned] [Bug 60221] Windows build of WebKit GTK needs to be able to find SystemInfo.h
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 4 15:48:40 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=60221
Martin Robinson <mrobinson at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #92332|review?, commit-queue? |review-
Flag| |
--- Comment #2 from Martin Robinson <mrobinson at webkit.org> 2011-05-04 15:48:40 PST ---
(From update of attachment 92332)
View in context: https://bugs.webkit.org/attachment.cgi?id=92332&action=review
Seems okay, but the ChangeLog format does not look correct.
> Source/WebCore/ChangeLog:10
> + Add Source/WebCore/platform/win to teh paths searched
> + for headers, since Source/WebCore/platform/win/SystemInfo.h
> + header is needed by Source/WebKit/gtk/webkit/webkitwebsettings.cpp
> + on Windows.
> + https://bugs.webkit.org/show_bug.cgi?id=60221
> +
teh -> the
The ChangeLog format should be
<bug title>
<bug url>
<description>
> Source/WebCore/ChangeLog:11
> + No new tests. (OOPS!)
You should remove this line or, even better, replace it with a short sentence saying why tests are not necessary. :)
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list