[Webkit-unassigned] [Bug 60210] REGRESSION (WebKit2): Windowed plugins don't scroll at the same speed as the rest of the page

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60210





--- Comment #5 from Adam Roben (:aroben) <aroben at apple.com>  2011-05-04 15:26:06 PST ---
(From update of attachment 92322)
View in context: https://bugs.webkit.org/attachment.cgi?id=92322&action=review

>> Source/WebKit2/UIProcess/win/WebView.cpp:1542
>> +{
> 
> Given this is only called in one place, why not always redraw? Do you have plans to use this elsewhere?

I don't have any immediate plans, no. I'll remove it. (Though having the parameter does make the call to ::SetWindowRgn a little clearer.)

>> Source/WebKit2/UIProcess/win/WebView.cpp:1560
>> +    for (HashMap<HWND, ChildWindowGeometry>::const_iterator it = geometriesToUpdate.begin(); it != end; ++it) {
> 
> In WebKit2 we declare both iterators inside the for loop:
> 
> HashMap<HWND, ChildWindowGeometry>::const_iterator it = geometriesToUpdate.begin(), end = geometriesToUpdate.end();

Fixed.

>> Source/WebKit2/WebProcess/Plugins/PluginController.h:93
>> +    virtual void scheduleWindowedPluginGeometryUpdate(HWND, const WebCore::IntRect& newRectInParentClientCoordinates, const WebCore::IntRect& clipRectInPluginWindowCoordinates) = 0;
> 
> Please add a comment to indicate what this function does, like with nativeParentWindow().

Added this comment:

// Tells the controller that the given HWND needs to be positioned and clipped to the given coordinates sometime soon.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.