[Webkit-unassigned] [Bug 60128] Compiler warning "eventWasHandled may be used without initialized" in WebView/WebHTMLView.mm.

Wed May 4 11:54:03 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=60128

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92263|review+                     |review-
               Flag|                            |

--- Comment #5 from Alexey Proskuryakov <ap at webkit.org>  2011-05-04 11:54:03 PST ---
(From update of attachment 92263)
I'm not thrilled with this change, because it makes the code a little more fragile. If someone edits it and forgets to assign a result to the variable in one of the branches, the compiler will no longer come to the rescue.

You should probably upstream a bigger chunk of code, and/or actually assign to the variable instead of simply ifdefing out one branch in your port.

Marking r- for now, but you could convince me that it's fine to land as is.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.