[Webkit-unassigned] [Bug 56200] [GTK] WebKitIconDatabase doesn't keep icons cached

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 4 10:10:57 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=56200





--- Comment #24 from Sergio Villar Senin <svillar at igalia.com>  2011-05-04 10:10:57 PST ---
(In reply to comment #22)
> (From update of attachment 92245 [details])
> > Source/WebKit/gtk/webkit/webkiticondatabase.cpp:436
> > + * be cached then it should listen to icon-changed signal in order to
> > + * know when the icon data is actually available. Otherwise if the
> > + * icon need to be retrieved from an external resource the client
> > + * should connect to icon-changed signal.
> 
> Shouldn't a developer listen for the icon-data-imported-signal? I'm not sure I fully understand the last sentence. :/

You're definitely right Martin, it is just that I forgot to change that paragraph in the last version of my patch.

BTW I'm not sure about what I should use for the "Since:" section of the documentation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list