[Webkit-unassigned] [Bug 42759] Always freeing m_logAttrs in TextBreakIteratorGtk.cpp: setUpIterator()

Wed May 4 07:18:19 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=42759

Peter Hatina <phatina at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92237|                            |review?
               Flag|                            |

--- Comment #3 from Peter Hatina <phatina at redhat.com>  2011-05-04 07:18:19 PST ---
Created an attachment (id=92237)
 --> (https://bugs.webkit.org/attachment.cgi?id=92237&action=review)
m_logAttrs freed when necessary

Wrt motivation: When breaking the text, I think, it is not always necessary to reallocate the memory block, if it is sufficient for future use. Also we save mem. allocation call and part of zero-ing proces, which is done only on the part of the portion. To my mind, it is also cheaper to use once-prepared block, than always release it and call for another one.

Wrt coding style: now it should be fine.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.