[Webkit-unassigned] [Bug 60160] Web Inspector: expose shadow DOM in the Elements panel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60160


Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92223|1                           |0
        is obsolete|                            |




--- Comment #5 from Yury Semikhatsky <yurys at chromium.org>  2011-05-04 06:28:53 PST ---
(From update of attachment 92223)
View in context: https://bugs.webkit.org/attachment.cgi?id=92223&action=review

> LayoutTests/inspector/elements/shadow-dom-expected.txt:20
> +        - <div>

Would be nice if the test used our own element with simpler shadow tree and would depend on the internal structure of <video> element.

> Source/WebCore/dom/Element.cpp:1188
> +    InspectorInstrumentation::willInsertDOMNode(document(), newRoot.get(), this);

Should it be willInsertShadowRoot?

> Source/WebCore/inspector/front-end/DOMAgent.js:321
> +            child._inShadowTree = this._inShadowTree;

This way all child nodes including non-shadow ones will be considered as shadow elements. We should support the case when an element with shadow tree contains non-shadow elements.

>> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:570
>> +	    // If we ever had shadow root child, it's going to be second to last (before closing tag)
> 
> Line contains tab character.  [whitespace/tab] [5]

Why is this? Can we check for the shadow root in a more clear way?

>> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:571
>> +	    var shadowRootChild = treeElement.children[treeElement.children.length - 2];
> 
> Line contains tab character.  [whitespace/tab] [5]

This will throw if children.length < 2.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.