[Webkit-unassigned] [Bug 60146] [CMAKE] Refactoring wtf related code.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 4 03:30:34 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=60146





--- Comment #2 from Patrick R. Gansterer <paroga at paroga.com>  2011-05-04 03:30:34 PST ---
(From update of attachment 92208)
View in context: https://bugs.webkit.org/attachment.cgi?id=92208&action=review

Expect for the wtf-files, LGTM

> Source/JavaScriptCore/CMakeLists.txt:-174
> -
> -    wtf/DateMath.cpp
> -    wtf/PageAllocationAligned.cpp
> -    wtf/PageBlock.cpp

I'm not sure if that's correct. Some other ports add this to JSC and not to WTF too. (I don't know why they do that and if i remenber corretly I had some problem with this files in in the WinCE port)
e.g. http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj?rev=83506#L641

At lest the move of the files can be put into an addtional patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list