[Webkit-unassigned] [Bug 56575] REGRESSION: "Hidden" NPAPI plugin not loaded

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56575





--- Comment #16 from Pere Martir <pere.martir4 at gmail.com>  2011-05-04 03:18:37 PST ---
(From update of attachment 88992)
View in context: https://bugs.webkit.org/attachment.cgi?id=88992&action=review

>> Source/WebCore/html/HTMLObjectElement.cpp:139
>> +            addCSSLength(attr, CSSPropertyHeight, "0");
> 
> I'm really not a big fan of this hack.
> 
> It's not clear to me why this is needed.  When did behavior change?  Do we know why it changed?  It should be relatively trivial to run Tools/Scripts/bisect-builds or git bisect and find the revision at which the bahavior changed in WebKIt.  Then we would better understand what change may be necessary to restore old behavior (or if the behavior change was intentional).

I've seen that you've found that it was due to changeset 73459, which accidentally broke the behavior of how "hidden" attribute works with OBJECT element. EMBED element has not been affect because HTMLEmbedElement.cpp has this "hack". Since HTML5 says the plugin should be instantiated no matter that it's visible or not, maybe this hack is the correct thing to do now. 

Related comment of this hack: https://bugs.webkit.org/show_bug.cgi?id=40511#c7

Quotation: "...The selected plugin is instantiated even if the element is hidden with a 'display:none' CSS style."

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.