[Webkit-unassigned] [Bug 56575] REGRESSION: "Hidden" NPAPI plugin not loaded

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56575


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88992|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #13 from Eric Seidel <eric at webkit.org>  2011-05-04 01:18:34 PST ---
(From update of attachment 88992)
View in context: https://bugs.webkit.org/attachment.cgi?id=88992&action=review

> Source/WebCore/html/HTMLObjectElement.cpp:139
> +            // FIXME: Not dynamic, since we add this but don't remove it, but it may be OK for now
> +            // that this rarely-used attribute won't work properly if you remove it.
> +            addCSSLength(attr, CSSPropertyWidth, "0");
> +            addCSSLength(attr, CSSPropertyHeight, "0");

I'm really not a big fan of this hack.

It's not clear to me why this is needed.  When did behavior change?  Do we know why it changed?  It should be relatively trivial to run Tools/Scripts/bisect-builds or git bisect and find the revision at which the bahavior changed in WebKIt.  Then we would better understand what change may be necessary to restore old behavior (or if the behavior change was intentional).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.