[Webkit-unassigned] [Bug 31507] REGRESSION: [CAIRO] wrong drawing of Gradients and Patterns on texts

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31507





--- Comment #15 from Eric Seidel <eric at webkit.org>  2011-05-03 22:18:06 PST ---
(From update of attachment 89073)
View in context: https://bugs.webkit.org/attachment.cgi?id=89073&action=review

Hmm... I predict you're gonna rewrite this again... I rewrote the gradient stuff for CG at least 3 times before it got to its current state...

> Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:786
> +    platformContext()->updateStrokeTransform();

I'm still not sure why you need the transform saved at this time and can't just use the CTM when the drawing is done?

> Source/WebCore/platform/graphics/cairo/PlatformContextCairo.cpp:39
> +    , m_strokeTransform(static_cast<cairo_matrix_t*>(fastMalloc(sizeof(cairo_matrix_t))))

Wow.  Really?  They don't provide any create function?

> Source/WebCore/platform/graphics/cairo/PlatformContextCairo.cpp:48
> +    fastFree(m_strokeTransform);

Why not just use an OwnPtr if we're just gonna malloc and free?  I guess ownptr calls delete... which would be bad... or?

> Source/WebCore/platform/graphics/cairo/PlatformContextCairo.cpp:101
> +    if (alpha >= 1)

What would this even mean?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.