[Webkit-unassigned] [Bug 45274] Breaking Float: floated block level element following inline element in floated container breaks to next line

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45274





--- Comment #22 from Dave Hyatt <hyatt at apple.com>  2011-05-03 15:01:34 PST ---
(From update of attachment 91643)
View in context: https://bugs.webkit.org/attachment.cgi?id=91643&action=review

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:1568
> +    bool floatFitsOnLine(float extra) const { return currentWidth() - additionalWidth() + extra <= m_availableWidth; }

Is it not sufficient to just ignore the uncommitted width here?  It seems like you're basically doing committed + uncommitted - uncommitted + extra, which works out to just being committed + extra.

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:2119
> +            if (currentCharacterIsSpace && additionalTmpW)
> +                width.setAdditionalWidth(additionalTmpW);

It seems wrong not to include inlineLogicalWidth here.  You might want to make a test for this case.  You should be able to just add it to additionalTmpW I would think.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.