[Webkit-unassigned] [Bug 59929] [Chromium] Make accelerated 2d canvas enabled by default with skia

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 3 11:12:50 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=59929





--- Comment #7 from Kenneth Russell <kbr at google.com>  2011-05-03 11:12:50 PST ---
(From update of attachment 91924)
View in context: https://bugs.webkit.org/attachment.cgi?id=91924&action=review

>>> Source/WebCore/page/Settings.cpp:722
>>> +void Settings::setLegacyAccelerated2dCanvasEnabled(bool enabled)
>> 
>> This is a chromium-only flag so I think it should only exist in the chromium websettings files much like it was done with the compositeToTexture flag in :
>> 
>> https://bugs.webkit.org/show_bug.cgi?id=52311
>> 
>> It will actually simplify things and you won't have to touch quite that many files.
> 
> I tried to do what you suggest, but the problem is that I can't figure out a clean way to access WebSettings from outside of WebKit/chromium/src.  I think your suggestion might not work for what we are trying to do here, unless I am missing something?

No, you are correct. You can't access the Chromium WebKit API from WebCore. You can access it from Chrome sources and from within WebKit/chromium/src. The way you've done things looks fine.

> Source/WebCore/page/Settings.h:492
> +        bool m_legacyAcceleratedCanvas2dEnabled : 1;

You need to initialize this new bit to false in the Settings constructor.

> Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h:100
> +#define WebKitLegacyAccelerated2dCanvasEnabledPreferenceKey @"WebKitLegacyAccelerated2dCanvasEnabled"

You don't need to touch any of these Mac-specific files. The Chromium port is the only one using this legacy accelerated canvas 2D code at this point, so it's better not to add the new flag to any of the other ports' WebPreferences-like classes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list