[Webkit-unassigned] [Bug 60016] [GTK] WidgetGtk setFocus can not access directly the widget in WK2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60016


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92056|review?                     |review+
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2011-05-03 10:29:09 PST ---
(From update of attachment 92056)
View in context: https://bugs.webkit.org/attachment.cgi?id=92056&action=review

Great stuff.

> Source/WebCore/platform/gtk/WidgetGtk.cpp:69
> +    Frame* frame = Frame::frameForWidget(this);
> +    if (frame) {

This can just be:
if (Frame* frame = Frame::frameForWidget(this)) {

or an  early return.

> Source/WebCore/platform/gtk/WidgetGtk.cpp:71
> +        Page* page = frame->page();
> +        page->chrome()->focus();

Also should just be frame->page()->chrome()->focus();

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.