[Webkit-unassigned] [Bug 58840] [chromium] Decouple layer visibility calculations from render surfaces / computed draw transforms

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58840





--- Comment #2 from Adrienne Walker <enne at google.com>  2011-05-03 08:45:49 PST ---
(In reply to comment #1)

> - make LayerRendererChromium::updatePropertiesAndRenderSurfaces() a generic function to calculate the draw transforms, visible regions, and z-order for a set of layers templated for LayerChromium+??? and CCLayerImpl+RenderSurfaceChromium so we can use the same codepath for LayerChromiums and CCLayerImpl.  This will also involve abstracting the "holds on to a z-order list of layers, transform and bounds" portion of RenderSurfaceChromium out from the "is usable as a render target and can draw itself" of RenderSurfaceChromium.

I was looking at some of this same code yesterday to try to better fix https://bugs.webkit.org/show_bug.cgi?id=59020.  The scissor rect / visible region calculation is wrong in one particular case, but I think there also needs to be some refactoring about where we calculate and store that scissor rect.  However, this sounds like exactly the same patch of code that you're about to uproot.

Would it make sense for you to try to address both at the same time? Otherwise, maybe I should postpone that fix until you're done reorganizing this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.