[Webkit-unassigned] [Bug 59702] [PATCH] Add missing _WIN32_WINNT and WINVER definitions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59702





--- Comment #6 from Kalev Lember <kalevlember at gmail.com>  2011-05-03 00:43:25 PST ---
Any other ideas where these definitions should go instead of config.h?

I think defining it only in the vsprops file isn't enough, as that file is specific to Visual Studio build system, whereas there are ports that use other build systems, for instance autotools. Each individual port might choose to tighten the deps even more (e.g. requiring WINVER=502 as Apple's Windows port is doing), but there should still be _minimal_ WINVER/_WIN32_WINNT definitions somewhere in buildsystem-agnostic code.

I am not entirely sure either where the right place for these definitions should be, but the attached patch at least brings JavaScriptCore in line with the rest of the projects and fixes a build failure with webkitgtk port.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.