[Webkit-unassigned] [Bug 59975] New: ValidityState::valid causes value sanitization 7 times

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59975

           Summary: ValidityState::valid causes value sanitization 7 times
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Forms
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: joepeck at webkit.org
                CC: tkent at chromium.org, dmikurube at google.com


I noticed this while working on value sanitization for date inputs.
This could be a performance issue, because sanitization requires
parsing the input to see if it is valid.

    bool ValidityState::valid() const
    {
        bool someError = typeMismatch() || stepMismatch() || rangeUnderflow() || rangeOverflow()
            || tooLong() || patternMismatch() || valueMissing() || customError();
        return !someError;
    }

It seems like this could really benefit from caching, or a better
design that allows for getting the sanitized value once, and running
the different validity tests on the pre-calculated value.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.