[Webkit-unassigned] [Bug 57242] webkit-patch should support a placeholder for the bug number

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 2 14:59:41 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=57242





--- Comment #5 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2011-05-02 14:59:41 PST ---
(In reply to comment #4)
> Can you tell me more about your workflow?
> 
> I don't create a bug until after I've written a patch, but then webkit-patch upload creates it for me (right before it asks me to write the ChangeLog).

I also write the patch first.

> I'm happy to help you make the tools better support whatever workflow you desire.  But I'm not sure I understand your workflow yet.

1. Write a patch and make it work with tests, etc.

2. Run prepare-ChangeLog and write the entry, including a placeholder for the bug like this:

<http://webkit.org/b/00000> Title of the bug goes here

2.5. Branch local repo to commit the fix on a branch.  (Sometimes this is Step 0 or Step 1.5.)

3. Run:  Tools/Scripts/webkit-patch create-bug --cc=<cc at list> --component="bogus component because I never remember the exact spelling and it prompts me anyway" --no-prompt HEAD

So I'm expecting webkit-patch to do (at least) one of the following:

- File the bug and then replace the bug number placeholder when uploading the patch.  (I don't recall whether webkit-patch mimics the extended HTML form not for uploading a patch with the bug creation.)

- Replace the bug number placeholder before landing the patch (which would let me CQ+ the patch if there are no other changes).

I would probably use "webkit-patch upload", except it makes me do extra work (like typing in a bug title when it's already in the ChangeLog I just wrote), it makes me write the ChangeLog after I already wrote one (last time I tried it; it's been a few months) and it still doesn't replace the bug number placeholder that I want to use.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list