[Webkit-unassigned] [Bug 56375] [Qt] PageGroup::closeLocalStorage() should be called when the app quits

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56375





--- Comment #9 from Antonio Gomes <tonikitoo at webkit.org>  2011-05-02 13:19:59 PST ---
(From update of attachment 91961)
View in context: https://bugs.webkit.org/attachment.cgi?id=91961&action=review

Sorry , I missed a few comments.

> Source/WebKit/qt/ChangeLog:12
> +        Close Local Storage when last QWebPage is destroyed.
> +
> +        Added an instance count to QWebPage.  Now when the last QWebPage
> +        is destroyed, we close local storage and icon database as done
> +        on other platforms.

Is this fixing any real world problem? a crash or what ever? can not this be tested?

> Source/WebKit/qt/Api/qwebpage.cpp:170
> +    WebCore::PageGroup::closeLocalStorage();
> +}
> +
> +

Unneeded extra line.

> Source/WebKit/qt/Api/qwebpage.cpp:393
> +    // if destroying last WebPage instance. Release resources.

remove the comment, it is clear from the code what is happening.

> Source/WebKit/qt/Api/qwebpage.cpp:395
> +    if (!instanceCount)
> +        shutDownWebKit();

I would add a assert before the 'if': ASSERT(instanceCount >= 0);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.