[Webkit-unassigned] [Bug 59951] Implement Date and Time Input Value Sanitization

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 2 12:28:51 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=59951





--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org>  2011-05-02 12:28:51 PST ---
(In reply to comment #2)
> I think a typeMismatch can still happen for a localized string.
> So, say a localized string implementation accepts "today" as
> a valid string. This would not sanitize that value, but
> typeMismatch might say it is invalid. I'll test this out.

Yes, this is the case with elem.value = 'today', but not the
case when the user types in "today", and convertVisibleValue
runs, and sets the internal value correctly. I think this is fine.

However, this pointed out to me that we can still get type
mismatches if a user types into the date field, because it
is a text field. I should update the tests to make sure that
if, instead of elem.value = '...', the user types '...' that there
is or is not a type mismatch.

Also, this may be a performance issue, since validity state
checking seems to run sanitization on each value change,
causing this to be run 7 times, which could be costly.
I'll post a follow-up.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list