[Webkit-unassigned] [Bug 59912] Automated Bug 5768 test from manual test.

Mon May 2 12:05:57 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=59912

--- Comment #9 from Naoki Takano <takano.naoki at gmail.com>  2011-05-02 12:05:57 PST ---
Thank you for your review every time.

(In reply to comment #8)
> > LayoutTests/fast/frames/frame-with-noresize-refresh.html:3
> > +<!--This test checks if multiple frame loading correctly refreshes layout with noresize attribute in frame.-->
> 
> It's more helpful to put this in body so that readers can see what the test is testing in the expected result.

Actually, we cannot use <body> tag with <frameset> at the same time.
Or should I move the message into frame1.html in <body>?

> Do we really need this switch statement?  Can't we just do something along the line of:
> if (!is_frame2 && !called_from_frame2)
>     f.src = "resources/frame2.html";
> else if (is_frame2)
>     f.src = "resources/frame1.html";
> else {
>     if (window.layoutTestController)
>     layoutTestController.notifyDone();
> }
Yes, you are right.
This is much clearer than switch version.

> > LayoutTests/fast/frames/resources/frame1.html:4
> > +<head>
> > +<title>frame1</title>
> > +</head>
> 
> Do we need title?
No, I can remove them.

> > LayoutTests/fast/frames/resources/frame1.html:7
> > +Frame 1.
> > +<div id="msg">First loading. FAIL if you see this message as the final message.</div>
> 
> Frame 1 and first loading are redundant.  You should put either but not both.
I will remain "Frame 1."

> > LayoutTests/fast/frames/resources/frame1.html:9
> > +  if(parent.parent.parent.test(false))
> 
> Why 3 parents??
We want to access to the test() function in frame-with-noresize-refresh.html.
The first parent is <frame> in frame-with-noresize-refresh.html and the second is <frameset> and the third is <body>.
So we need 3 parents.

> > LayoutTests/fast/frames/resources/frame1.html:10
> > +    document.getElementById('msg').innerText = "SUCCESS to load twice.";
> 
> I don't think you need to say " to load twice".  PASS or SUCCESS suffice.
Sure.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.