[Webkit-unassigned] [Bug 59922] [EFL] Cleanup EFL initialization/shutdown in the EWebLauncher

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59922





--- Comment #8 from Lucas De Marchi <demarchi at webkit.org>  2011-05-02 08:40:38 PST ---
(In reply to comment #7)
> Thank you for your comment. Generally I agre with you. This is a good way. 
> But in this specific case where we use our own _WebKit engine library_ this 

What do you mean by "our own webkit engine library"? Besides being a browser for testing the EFL port, EWebLauncher serves as a demo how a browser would be done with this port.

> redundant initialization makes only code confusion. We exactly know what 

Why? This is a common agreement among EFL developers: you init what you use. If your application uses evas, you init evas; if it uses ecore_evas, you init ecore_evas... even if evas is actually initialized by ecore_evas_init().

> initialization function will do and it is hard to belive that the EFL
> initialization code will disappears from there. :) Moreover, when I use an
> engine I expect that a lot of think like initializations will be done on the
> engine site without my control.

Exactly because it's without your control, you shouldn't trust it.


> 
> Should we also move glib initialization to EWebLauncher to be consistent? :)

If you use a function in glib's namespace, I'd say yes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.