[Webkit-unassigned] [Bug 59927] New: [SH4] AssemblerLabel does not name a type

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59927

           Summary: [SH4] AssemblerLabel does not name a type
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: thouraya.andolsi at st.com


Hello,

Updating webkit, I have got the following error : error: AssemblerLabel does not name a type.

The issue is caused by the work done to Use AssemblerLabel throughout Assembler classes.

To fix the problem, I have to change the define order inf MacroAssemblerSH4.h as follow

#include "SH4Assembler.h"
#include "AbstractMacroAssembler.h"

But I'll get a webkit style problem :Alphabetical sorting problem.  [build/include_order] [4]


I have another solution which is to add:

# inculde AbstractMacroAssembler.h in AbstractMacroAssembler.h

What do you suggest as a solution? I'm preparing  a patch.

I think there is the same issue in MIPS platforms.

Regards,
Thouraya

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.