[Webkit-unassigned] [Bug 59912] Automated Bug 5768 test from manual test.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59912


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91875|review?                     |review-
               Flag|                            |




--- Comment #4 from Adam Barth <abarth at webkit.org>  2011-05-01 19:58:40 PST ---
(From update of attachment 91875)
View in context: https://bugs.webkit.org/attachment.cgi?id=91875&action=review

> LayoutTests/fast/frames/frame-with-noresize-refresh.html:12
> +if (window.layoutTestController)
> +    layoutTestController.dumpAsText();
> +
> +if (window.layoutTestController)
> +    layoutTestController.dumpChildFramesAsText();
> +
> +if (window.layoutTestController)
> +    layoutTestController.waitUntilDone();

This can all be combined into one if-block.

> LayoutTests/fast/frames/frame-with-noresize-refresh.html:14
> +alert("This test checks if multiple frame loading correctly refreshes layout with noresize attribute in frame.");

I'd just make this a comment instead of an alert.  An alert can be annoying when running the test manually.

> LayoutTests/fast/frames/frame-with-noresize-refresh.html:23
> +            window.setTimeout(test, 100);

Why these set timeouts?  They look like race conditions to me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.