[Webkit-unassigned] [Bug 59896] New: Remove JmpSrc/JmpDst types.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 1 14:44:03 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=59896

           Summary: Remove JmpSrc/JmpDst types.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: barraclough at apple.com


The JmpSrc/JmpDst classes predate the MacroAssembler interface.  Having these object be per-assembler in unhelpful, causes unnecessary code duplication, and prevents the AssemblerBuffer from providing a richer type for labels.  The limited semantic meaning that they did convey is undermined by the manner in which their meanings have been overloaded (use of JmpSrc for Call, JmpDst for data labels).

Jumps on ARMv7 have had additional information added to the object via the ARMv7 JmpSrc.  This data should probably be in the instruction stream.  This patch does not fix the problem, and moves the data (ifdefed) to AbstractMacroAssembler::Jump (which is effectively where it was before!).  This at least closes the hole such that no further data may be added to JmpSrc, but this is unfortunate, and should be cleaned up.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list