[Webkit-unassigned] [Bug 57336] experiment with moving caret by word in visual order

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57336


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87718|review?                     |review+
               Flag|                            |




--- Comment #16 from Ryosuke Niwa <rniwa at webkit.org>  2011-03-31 07:17:00 PST ---
(From update of attachment 87718)
View in context: https://bugs.webkit.org/attachment.cgi?id=87718&action=review

> Source/WebCore/editing/visible_units.cpp:1163
> +    // FIXME: handle multi-spaces. Please refer bug https://bugs.webkit.org/show_bug.cgi?id=57543 for detail.

Just say "FIXME: handle multi-spaces (https://webkit.org/b/57543)".

> Source/WebCore/editing/visible_units.cpp:1166
> +    if (previousWordBreak != wordBreak) {

Let's do early exit here instead.

> Source/WebCore/editing/visible_units.cpp:1170
> +        if (boxContainingPreviousWordBreak == box)
> +            return wordBreak;

Ditto. do:
if (boxContainingPreviousWordBreak != box)
    return VisiblePosition();
return wordBreak;

> Source/WebCore/editing/visible_units.cpp:1197
> +        // FIXME: "else" not implemented yet.

FIXME: Implement the "else" case.

> Source/WebCore/editing/visible_units.cpp:1211
> +        // FIXME: "else" not implemented yet.

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.