[Webkit-unassigned] [Bug 57535] Fix compilation on Solaris 10 with Sun Studio 12, missing definition for time_t

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57535





--- Comment #3 from Ben Taylor <bentaylor.solx86 at gmail.com>  2011-03-31 05:05:59 PST ---
(In reply to comment #2)
> Attachment 87700 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
> 
> Source/WebCore/page/Page.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
> Source/WebCore/loader/icon/IconRecord.h:41:  One space before end of line comments  [whitespace/comments] [5]
> Source/WebCore/loader/icon/IconRecord.h:41:  Alphabetical sorting problem.  [build/include_order] [4]
> Source/WebCore/platform/network/ResourceResponseBase.h:38:  One space before end of line comments  [whitespace/comments] [5]
> Source/WebCore/platform/network/ResourceResponseBase.h:38:  Alphabetical sorting problem.  [build/include_order] [4]
> Total errors found: 5 in 4 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

They look like false positives to me. Reverting the patch and rerunning check-webkit-style on loader/icon/IconRecord.h emits the following messages.  However, if someone can tell me if the order needs to be changed on the includes, happy to make the change.  The space issue is clearly false positive since the C++ style comments in the lines cause that issue

Source/WebCore/loader/icon/IconRecord.h:34:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/loader/icon/IconRecord.h:36:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/loader/icon/IconRecord.h:78:  The parameter name "data" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/loader/icon/IconRecord.h:107:  Should only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/loader/icon/IconRecord.h:114:  Should have a space between // and comment  [whitespace/comments] [4]

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.