[Webkit-unassigned] [Bug 44329] SH4 JIT SUPPORT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44329





--- Comment #104 from thouraya <thouraya.andolsi at st.com>  2011-03-31 04:25:35 PST ---
Hello,

I did  such a changes because I saw that the putIntegral was just called in AssemblerBufferWithConstantPool.h file.

Now, I removed my changes an submitted a new patch but has got the error related to the style.

Is the patch OK?
Should I fix the style issue ?

Many thanks for the review.

Regards,
Thouraya.

(In reply to comment #99)
> > > Source/JavaScriptCore/assembler/AssemblerBuffer.h:-131
> > > -        template<typename IntegralType>
> > > -        void putIntegral(IntegralType value)
> > 
> > Why is this change here?  This is a cross platform type so adding a new JIT backend shouldn't  result in functions being removed -- are they only used for the constant pool backends?
> > 
> > I think these should stay in the root assembler buffer so we don't have unnecessary changes in this patch
> 
> Well, I asked Thouraya to move 'putIntegral.*TwoShorts' functions from this patch https://bug-46796-attachments.webkit.org/attachment.cgi?id=86911 to AssemblerBufferWithConstantPool level. But I did not mean to move all 'putIntegral.*IntegralType' template functions to AssemblerBufferWithConstantPool. So, my suggestion was to move only 'void putIntegral(TwoShorts value)' and 'void putIntegralUnchecked(TwoShorts value)' functions to AssemblerBufferWithConstantPool.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.