[Webkit-unassigned] [Bug 57382] [chromium] UnlockNonLocked condition reached in WorkerFileSystemsCallbackBridge::mayPostTaskToWorker

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 30 16:53:56 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=57382





--- Comment #10 from Kinuko Yasuda <kinuko at chromium.org>  2011-03-30 16:53:55 PST ---
(From update of attachment 87636)
This change looks good to me now.  I wanted to get rid of m_selfRef but wasn't able to think of a solution.
Thanks very much!

View in context: https://bugs.webkit.org/attachment.cgi?id=87636&action=review

> Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp:345
> +    if (!bridge->m_worker) // Since this check is just an optimization, it doesn't matter that the usage isn't threadsafe.

I think we can just remove these lines?  (I'm afraid tsan will warn on this check.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list