[Webkit-unassigned] [Bug 48512] [GTK] Implement sample browser app for WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48512


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87511|review?                     |review+
               Flag|                            |




--- Comment #28 from Martin Robinson <mrobinson at webkit.org>  2011-03-30 15:28:06 PST ---
(From update of attachment 87511)
View in context: https://bugs.webkit.org/attachment.cgi?id=87511&action=review

> Tools/MiniBrowser/gtk/main.c:133
> +    const gchar *uri = argc > 1 ? argv[1] : "http://www.webkitgtk.org/";
> +    gchar *fileURL = filenameToURL(uri);
> +
> +    WKPageLoadURL(WKViewGetPage(webView), WKURLCreateWithURL(fileURL));
> +    g_free(fileURL);

Please change this to be (including changing the name of filenameToURL to argumentToURL):

gchar* url = argumentToURL(argc > 1 ? argv[1] : "http://www.webkitgtk.org/");
WKPageLoadURL(WKViewGetPage(webView), WKURLCreateWithURL(url));
g_free(url);

We do not necessarily know if the argument is a path or a URL or whether the result is a file or web URL.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.