[Webkit-unassigned] [Bug 57418] [Qt] [Symbian] GraphicsLayer: support plugins on symbian

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57418





--- Comment #5 from Viatcheslav Ostapenko <ostapenko.viatcheslav at nokia.com>  2011-03-30 08:33:47 PST ---
(In reply to comment #4)
> (From update of attachment 87465 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=87465&action=review
> 
> Is there no way to test this?
> There are changes to PluginView which do not look Symbian specific, can't they be commited separately with test coverage?

What is not symbian specific? Moving out m_platformLayer definition out of XP_UNIX ifdef? ;)
I have similar patch coming for windows, so all platforms should be covered.
In any case, having unused m_platformLayer member shouldn't harm.

> > Source/WebCore/plugins/symbian/PluginViewSymbian.cpp:93
> > +// Qt's GraphicsLayer (GraphicsLayerQt) requires layers to be QGraphicsWidgets
> 
> Missing dot at the end of the sentence.
> Useless comment anyway, it does not add information/explanation, you can remove it.

Copy paste from Linux patch ;)

> > Source/WebCore/plugins/symbian/PluginViewSymbian.cpp:112
> > +        clipRect.translate(-clipRect.topLeft());
> 
> That looks weird, are you trying to map and object from content coordinate to window coordinate?

Yes. What's weird here? It assigned from frameRect one line upper.
Would this

QRectF clipRect(m_view->frameRect().translated(-m_view->frameRect().topLeft()));

look better? ;)

> > Source/WebCore/plugins/symbian/PluginViewSymbian.cpp:118
> > +        rect.adjust(-1, -1, 1, 1);
> 
> WHAAAAAAAAT?
> That deserve a comment :)

It is converted from QRectF to QRect. I see artifacts with animated transparent plugins when QGraphicsWebView is scaled.
Here is sample: goo.gl/uhgYk

> > Source/WebCore/plugins/symbian/PluginViewSymbian.cpp:484
> > +            // Trigger layer computation in RenderLayerCompositor
> 
> Not period at the end of the sentence.
> Useless comment anyway.

Copy/paste again ;)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.