[Webkit-unassigned] [Bug 57336] experiment with moving caret by word in visual order

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57336





--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org>  2011-03-30 07:39:16 PST ---
(From update of attachment 87522)
View in context: https://bugs.webkit.org/attachment.cgi?id=87522&action=review

> Source/WebCore/editing/visible_units.cpp:1268
> +    // In order to get the correct word boundary (the one before space or the one after space), 

This repeats what code does.  We need to explain "why" we need to do this in order to get the correct word boundary instead.

> Source/WebCore/editing/visible_units.cpp:1271
> +    if ((directionToSearch == WebCore::DirectionRight && blockDirection == LTR) 
> +        || (directionToSearch == WebCore::DirectionLeft && blockDirection == RTL)) {

I think this condition should be in wordBoundaryInAdjacentBoxes and we should split wordBoundaryInBox into two functions.
Maybe findWordBoundaryInBoxInBlockDirection?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.