[Webkit-unassigned] [Bug 57418] [Qt] [Symbian] GraphicsLayer: support plugins on symbian

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57418


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87465|review?                     |review-
               Flag|                            |




--- Comment #4 from Benjamin Poulain <benjamin at webkit.org>  2011-03-30 04:59:21 PST ---
(From update of attachment 87465)
View in context: https://bugs.webkit.org/attachment.cgi?id=87465&action=review

Is there no way to test this?
There are changes to PluginView which do not look Symbian specific, can't they be commited separately with test coverage?

> Source/WebCore/plugins/symbian/PluginViewSymbian.cpp:93
> +// Qt's GraphicsLayer (GraphicsLayerQt) requires layers to be QGraphicsWidgets

Missing dot at the end of the sentence.
Useless comment anyway, it does not add information/explanation, you can remove it.

> Source/WebCore/plugins/symbian/PluginViewSymbian.cpp:112
> +        clipRect.translate(-clipRect.topLeft());

That looks weird, are you trying to map and object from content coordinate to window coordinate?

> Source/WebCore/plugins/symbian/PluginViewSymbian.cpp:118
> +        rect.adjust(-1, -1, 1, 1);

WHAAAAAAAAT?
That deserve a comment :)

> Source/WebCore/plugins/symbian/PluginViewSymbian.cpp:484
> +            // Trigger layer computation in RenderLayerCompositor

Not period at the end of the sentence.
Useless comment anyway.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.