[Webkit-unassigned] [Bug 57434] [GTK] Implement scheduleWorkAfterDelay() in WorkQueueGtk

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 30 02:28:25 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=57434


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87487|                            |review?
               Flag|                            |




--- Comment #1 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-03-30 02:28:25 PST ---
Created an attachment (id=87487)
 --> (https://bugs.webkit.org/attachment.cgi?id=87487&action=review)
Patch

- Implement scheduleWorkAfterDelay() using a timeout source
- Use an idle source instead of a timeout one with 0 for scheduleWork()
- Don't use a lock for g_source_attach() since it uses its own mutex internally
- Don't leak the GSource, g_source_attach() increments the source reference counter
- Use a GSocket instead of GIOChannel
- Factor out performWork() and performWorkOnce() to avoid duplicated code

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list