[Webkit-unassigned] [Bug 9272] Left/Right borders/padding/margins are not always added correctly when rendering multiline inline boxes with bidi elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=9272


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87481|review?                     |review+
               Flag|                            |




--- Comment #22 from Eric Seidel <eric at webkit.org>  2011-03-30 01:11:23 PST ---
(From update of attachment 87481)
Fantastic!

I think an ideal follow-up pach would include splitting the includeLeftEdge/includeRightEdge calculation out of determineSpacingForFlowBoxes into a new function (determineEdges?) which can use early return.  I think the code would end up even simpler then.

This looks great though!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.