[Webkit-unassigned] [Bug 57307] [GTK] Fix leaked pointer in FontGtk.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57307





--- Comment #5 from Ryuan Choi <ryuan.choi at samsung.com>  2011-03-29 19:33:13 PST ---
(In reply to comment #3)
> (From update of attachment 87280 [details])
> Great catch! I think we can use this opportunity to clean this code up a bit. We should probably make utf16_to_utf8 return a char* instead of taking a char*& (which is bad form, IMO). Then in the caller we should immediately place the return value in a GOwnPtr<gchar> and remove the calls to g_free. This will prevent any mistakes in the future as well.

I update patch as mentioned with refactoring utf16_to_utf8(because of fixing indentation and coding style).

And also, can we remove 'from' variable in convertUniCharToUTF8?
this value will be passed 0 always.

Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.