[Webkit-unassigned] [Bug 57290] Make validation message bubble testable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57290





--- Comment #2 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2011-03-29 19:12:40 PST ---
(From update of attachment 87451)
View in context: https://bugs.webkit.org/attachment.cgi?id=87451&action=review

> Source/WebCore/html/ValidationMessage.cpp:103
> +    int magnification = doc->page() ? doc->page()->settings()->validationMessageTimerMaginification() : -1;
> +    if (magnification <= 0)
> +        m_timer.clear();
> +    else {
> +        m_timer.set(new Timer<ValidationMessage>(this, &ValidationMessage::deleteBubbleTree));
> +        m_timer->startOneShot(max(5.0, static_cast<double>(m_message.length()) * magnification / 1000));
> +    }

Why do we need the concept of magnification? Can it just be N seconds or indefinite switch?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.