[Webkit-unassigned] [Bug 57400] New: Fullscreen code assumes all layers use GPU compositing when USE(ACCELERATED_COMPOSITING)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57400

           Summary: Fullscreen code assumes all layers use GPU compositing
                    when USE(ACCELERATED_COMPOSITING)
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Platform
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ddorwin at chromium.org
                CC: jer.noble at apple.com


Document::webkitWillEnterFullScreenForElement, Document::webkitDidEnterFullScreenForElement, and Document::webkitWillExitFullScreenForElement all assert that m_fullScreenRenderer->layer()->backing() is valid inside the #if USE(ACCELERATED_COMPOSITING) blocks. However, accelerated compositing may be compiled in but disabled at runtime or for some elements. This is the case for Chromium, which supports a command line switch and does not currently accelerate all types of elements. In addition, the layout tests do not run with GPU acceleration enabled by default.

These asserts and subsequent use of a NULL backing cause the fullscreen tests to crash in the non-GPU-enabled runs of DumpRenderTree and when Chrome is run without GPU acceleration enabled.

I have a fix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.