[Webkit-unassigned] [Bug 57393] New: Extensions3D class API needs to be improved

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57393

           Summary: Extensions3D class API needs to be improved
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebGL
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: cmarrin at apple.com


Currently Extensions3D has several API calls whose signatures are wrong or confusing. For instance ensureEnabled() requires that the passed extension be supported (as indicated by supports()). But it says nothing about the consequences of violating that rule. In the implementation in Extensions3DOpenGL.cpp it doesn't even check if building for MAC and asserts otherwise. The call would be better if it were simply enable() and returned a boolean. False would indicate that the extension was not supported and therefore not enabled. Then the caller can take the appropriate action.

There are also several API calls, such as "bool supports(const String&)" which should be const.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.