[Webkit-unassigned] [Bug 49791] [GTK] Implement SharedMemory for WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49791





--- Comment #30 from Martin Robinson <mrobinson at webkit.org>  2011-03-29 12:36:11 PST ---
(In reply to comment #28)
> (From update of attachment 85555 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=85555&action=review
> 
> I guess you should remove ConnectionGtk.cpp too.
> 
> > Source/WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp:105
> > +void Connection::platformInvalidate()
> > +{
> 
> You should call m_connectionQueue.unregisterEventSourceHandler(m_socketDescriptor); for GTK platform here before closing the socket

Thanks for the review Carlos. I've uploaded a new patch fixing these issues.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.