[Webkit-unassigned] [Bug 57019] JavaInstance should not use jvalue in its API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57019





--- Comment #4 from Andrei Popescu <andreip at google.com>  2011-03-29 11:31:12 PST ---
LGTM

View in context: https://bugs.webkit.org/attachment.cgi?id=87296&action=review

> Source/WebCore/bridge/jni/v8/JavaInstanceV8.cpp:76
> +    jvalue* jvalueArgs = new jvalue[numParams];

Is there a scoped_pointer for arrays?

> Source/WebCore/bridge/jni/v8/JavaInstanceV8.cpp:78
> +        jvalueArgs[i] = javaValueToJvalue(args[i]);

Maybe add a comment to say that args is guaranteed to have at least numParams elements.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.