[Webkit-unassigned] [Bug 50952] Inputs of type "text" and "search" should support interoperable "set direction" functionality

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50952





--- Comment #12 from mitz at webkit.org  2011-03-29 09:31:17 PST ---
(From update of attachment 87313)
View in context: https://bugs.webkit.org/attachment.cgi?id=87313&action=review

> Source/WebKit/mac/WebView/WebViewPrivate.h:594
> +    @result Returns the default minimum timer interval.

This comment is wrong.

> Source/WebKit/mac/WebView/WebViewPrivate.h:596
> +- (void)_setTextDirection:(int)direction;

I think this SPI is unnecessary, and therefore should not be added. It’s especially bad that it takes an int parameter whose meaning is not clear at all.

WebView has -makeBaseWritingDirectionLeftToRight: and -makeBaseWritingDirectionRightToLeft: and a degenerate implementation of -makeBaseWritingDirectionNatural:. Can DumpRenderTree use those?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.